Block parameters #3

omghax · 2015-05-21T22:51:44Z

This PR removes usage of parentView in the various components, as suggested in emberjs/ember.js#11170. ivy-tabs and ivy-tab-list now yield themselves as a block parameter, which you then pass to their children.

Here's an example:

{{#ivy-tabs as |tabs|}}
  {{#ivy-tab-list ivy-tabs=tabs as |list|}}
    {{#ivy-tab ivy-tab-list=list}}Tab 1{{/ivy-tab}}
    ...
  {{/ivy-tab-list}}

  {{#ivy-tab-panel ivy-tabs=tabs}}Panel 1{{/ivy-tab-panel}}
  ...
{{/ivy-tabs}}

Once Ember supports scoped HTMLBars helpers, this could be shortened to:

{{#ivy-tabs as |tabs|}}
  {{#tabs.ivy-tab-list as |list|}}
    {{#list.ivy-tab}}Tab 1{{/list.ivy-tab}}
    ...
  {{/tabs.ivy-tabs}}

  {{#tabs.ivy-tab-panel}}Panel 1{{/tabs.ivy-tab-panel}}
  ...
{{/ivy-tabs}}

omghax · 2015-05-26T15:38:56Z

Due to the Ember core team's decision not to deprecate parentView until scoped htmlbars helpers land, this PR will likely not be merged. Rather, we can continue using ivy-tabs as it currently exists until I can switch it to use the scoped syntax and release a 2.0 version.

This was only being used by the (now removed) standalone builds.

The `parentView` property is slated to be removed, and doesn't appear to work properly in Ember 1.13. This change fixes that. Ideally we'll be able to use Ember 2.3's contextual components feature to make this even nicer.

This also upgrades `ember` to 2.4.1.

omghax added 10 commits March 23, 2016 20:01

Fix deprecated {{#each x in y}} usage

fb6162f

Use htmlbars-inline-precompile

0d08f9e

Move tests to tests/integration

48645f6

Simplify build, remove broccoli-funnel

f3898f9

Replace var with const / let

477d87d

Remove index file

903222c

This was only being used by the (now removed) standalone builds.

Use block params instead of parentView

23d850d

The `parentView` property is slated to be removed, and doesn't appear to work properly in Ember 1.13. This change fixes that. Ideally we'll be able to use Ember 2.3's contextual components feature to make this even nicer.

Remove unnecessary init hooks

faba37c

Use ES6 shorthand method syntax

e4ad353

Pass arguments to this._super

72ffcfa

omghax force-pushed the block-parameters branch from eac8424 to 72ffcfa Compare March 24, 2016 17:31

omghax added 3 commits March 24, 2016 13:53

Upgrade ember-cli to 2.4.2

04a397e

This also upgrades `ember` to 2.4.1.

Emit deprecation warnings when using parentView

b702722

Fix deprecation warnings in dummy app

e5c933b

omghax merged commit 504297e into master Mar 24, 2016

omghax deleted the block-parameters branch March 24, 2016 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block parameters #3

Block parameters #3

omghax commented May 21, 2015

omghax commented May 26, 2015

Block parameters #3

Block parameters #3

Conversation

omghax commented May 21, 2015

omghax commented May 26, 2015